-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Accessibility for themes - Lighthouse Integration #64
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for academic-folio ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is the report from lighthouse.
|
This reverts commit 7062e92.
Second issue is easily resolved. For the first issue, I think we have to use a different background color for codes and shortcodes (just like al-folio). What are your ideas? @rohandebsarkar |
Also, I added lighthouse integration. To see the results, you should go to we should define our metrics in |
Also, we are not using our primary color in any way. I think we should add our primary color to links like al-folio. This way it would be more alive. |
I feel we should use different theme colors for light and dark theme. A single color does not look good on both the themes. |
I will be open to add background color to codes. But the problem is we would have to add another color variable. |
I think that's okay. I mean, there is no other choice. |
I agree. However, I am not an expert in color theory and this stuff. I need to consult a UI designer to help me get good codes. |
Using https://pagespeed.web.dev/
Closes